Commit 4db7e178 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Wolfram Sang
Browse files

i2c: busses: Use fallthrough pseudo-keyword 

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through



Acked-by: default avatarBaruch Siach <baruch@tkos.co.il>
Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
Reviewed-by: default avatarBrendan Higgins <brendanhiggins@google.com>
Reviewed-by: default avatarGregory CLEMENT <gregory.clement@bootlin.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 3f110115

drivers/i2c/busses/i2c-amd8111.c

+1 −1
Original line number Diff line number Diff line
@@ -381,7 +381,7 @@ static s32 amd8111_access(struct i2c_adapter * adap, u16 addr, 
			if (status)

				return status;

			len = min_t(u8, len, I2C_SMBUS_BLOCK_MAX);

			/* fall through */

			fallthrough;

		case I2C_SMBUS_I2C_BLOCK_DATA:

			for (i = 0; i < len; i++) {

				status = amd_ec_read(smbus, AMD_SMB_DATA + i,

drivers/i2c/busses/i2c-aspeed.c

+2 −2
Original line number Diff line number Diff line
@@ -504,7 +504,7 @@ static u32 aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus, u32 irq_status) 
			goto error_and_stop;

		}

		irq_handled |= ASPEED_I2CD_INTR_TX_ACK;

		/* fall through */

		fallthrough;

	case ASPEED_I2C_MASTER_TX_FIRST:

		if (bus->buf_index < msg->len) {

			bus->master_state = ASPEED_I2C_MASTER_TX;
@@ -520,7 +520,7 @@ static u32 aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus, u32 irq_status) 
		/* RX may not have completed yet (only address cycle) */

		if (!(irq_status & ASPEED_I2CD_INTR_RX_DONE))

			goto out_no_complete;

		/* fall through */

		fallthrough;

	case ASPEED_I2C_MASTER_RX:

		if (unlikely(!(irq_status & ASPEED_I2CD_INTR_RX_DONE))) {

			dev_err(bus->dev, "master failed to RX\n");

drivers/i2c/busses/i2c-designware-pcidrv.c

+1 −1
Original line number Diff line number Diff line
@@ -90,7 +90,7 @@ static int mfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c) 
	switch (pdev->device) {

	case 0x0817:

		dev->timings.bus_freq_hz = I2C_MAX_STANDARD_MODE_FREQ;

		/* fall through */

		fallthrough;

	case 0x0818:

	case 0x0819:

		c->bus_num = pdev->device - 0x817 + 3;

drivers/i2c/busses/i2c-digicolor.c

+1 −1
Original line number Diff line number Diff line
@@ -187,7 +187,7 @@ static irqreturn_t dc_i2c_irq(int irq, void *dev_id) 
			break;

		}

		i2c->state = STATE_WRITE;

		/* fall through */

		fallthrough;

	case STATE_WRITE:

		if (i2c->msgbuf_ptr < i2c->msg->len)

			dc_i2c_write_buf(i2c);

drivers/i2c/busses/i2c-i801.c

+4 −4
Original line number Diff line number Diff line
@@ -1765,19 +1765,19 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) 
	case PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS_MS1:

	case PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS_MS2:

		priv->features |= FEATURE_IDF;

		/* fall through */

		fallthrough;

	default:

		priv->features |= FEATURE_BLOCK_PROC;

		priv->features |= FEATURE_I2C_BLOCK_READ;

		priv->features |= FEATURE_IRQ;

		/* fall through */

		fallthrough;

	case PCI_DEVICE_ID_INTEL_82801DB_3:

		priv->features |= FEATURE_SMBUS_PEC;

		priv->features |= FEATURE_BLOCK_BUFFER;

		/* fall through */

		fallthrough;

	case PCI_DEVICE_ID_INTEL_82801CA_3:

		priv->features |= FEATURE_HOST_NOTIFY;

		/* fall through */

		fallthrough;

	case PCI_DEVICE_ID_INTEL_82801BA_2:

	case PCI_DEVICE_ID_INTEL_82801AB_3:

	case PCI_DEVICE_ID_INTEL_82801AA_3: