Commit 4da3c718 authored by Gao Xiang's avatar Gao Xiang
Browse files

erofs: drop unnecessary WARN_ON() in erofs_kill_sb() 

Previously, .kill_sb() will be called only after fill_super fails.
It will be changed [1].

Besides, checking for s_magic in erofs_kill_sb() is unnecessary from
any point of view.  Let's get rid of it now.

[1] https://lore.kernel.org/r/20230731-flugbereit-wohnlage-78acdf95ab7e@brauner



Signed-off-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Acked-by: default avatarChristian Brauner <brauner@kernel.org>
Link: https://lore.kernel.org/r/20230801014737.28614-1-hsiangkao@linux.alibaba.com
parent 94c43de7

fs/erofs/super.c

+0 −2
Original line number Diff line number Diff line
@@ -889,8 +889,6 @@ static void erofs_kill_sb(struct super_block *sb) 
{

	struct erofs_sb_info *sbi;



	WARN_ON(sb->s_magic != EROFS_SUPER_MAGIC);



	/* pseudo mount for anon inodes */

	if (sb->s_flags & SB_KERNMOUNT) {

		kill_anon_super(sb);