Commit 4d9890ac authored by Rob Herring's avatar Rob Herring Committed by Alexandre Belloni
Browse files

rtc: sun6i: Use of_property_present() for testing DT property presence 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
Reviewed-by: default avatarAndre Przywara <andre.przywara@arm.com>
Link: https://lore.kernel.org/r/20230310144736.1547041-1-robh@kernel.org


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent f12f0c7d

drivers/rtc/rtc-sun6i.c

+1 −1
Original line number Diff line number Diff line
@@ -260,7 +260,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node, 
	}



	/* Switch to the external, more precise, oscillator, if present */

	if (of_get_property(node, "clocks", NULL)) {

	if (of_property_present(node, "clocks")) {

		reg |= SUN6I_LOSC_CTRL_EXT_OSC;

		if (rtc->data->has_losc_en)

			reg |= SUN6I_LOSC_CTRL_EXT_LOSC_EN;