Commit 4d8586e0 authored by Gavrilov Ilia's avatar Gavrilov Ilia Committed by Andrew Morton
Browse files

relay: fix type mismatch when allocating memory in relay_create_buf() 

The 'padding' field of the 'rchan_buf' structure is an array of 'size_t'
elements, but the memory is allocated for an array of 'size_t *' elements.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Link: https://lkml.kernel.org/r/20221129092002.3538384-1-Ilia.Gavrilov@infotecs.ru


Fixes: b86ff981 ("[PATCH] relay: migrate from relayfs to a generic relay API")
Signed-off-by: default avatarIlia.Gavrilov <Ilia.Gavrilov@infotecs.ru>
Cc: Colin Ian King <colin.i.king@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: wuchi <wuchi.zero@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent c9a934c7

kernel/relay.c

+2 −2
Original line number Diff line number Diff line
@@ -148,13 +148,13 @@ static struct rchan_buf *relay_create_buf(struct rchan *chan) 
{

	struct rchan_buf *buf;



	if (chan->n_subbufs > KMALLOC_MAX_SIZE / sizeof(size_t *))

	if (chan->n_subbufs > KMALLOC_MAX_SIZE / sizeof(size_t))

		return NULL;



	buf = kzalloc(sizeof(struct rchan_buf), GFP_KERNEL);

	if (!buf)

		return NULL;

	buf->padding = kmalloc_array(chan->n_subbufs, sizeof(size_t *),

	buf->padding = kmalloc_array(chan->n_subbufs, sizeof(size_t),

				     GFP_KERNEL);

	if (!buf->padding)

		goto free_buf;