Commit 4d671957 authored by vulab's avatar vulab Committed by Greg Kroah-Hartman
Browse files

USB: yurex: remove needless check before usb_free_coherent() 



usb_free_coherent() is safe with NULL addr and this check is
not required.

Signed-off-by: default avatarXu Wang <vulab@iscas.ac.cn>
Link: https://lore.kernel.org/r/20200810020802.9082-1-vulab@iscas.ac.cn


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1100395d

drivers/usb/misc/yurex.c

+2 −4
Original line number Diff line number Diff line
@@ -96,14 +96,12 @@ static void yurex_delete(struct kref *kref) 
	if (dev->cntl_urb) {

		usb_kill_urb(dev->cntl_urb);

		kfree(dev->cntl_req);

		if (dev->cntl_buffer)

		usb_free_coherent(dev->udev, YUREX_BUF_SIZE,

				dev->cntl_buffer, dev->cntl_urb->transfer_dma);

		usb_free_urb(dev->cntl_urb);

	}

	if (dev->urb) {

		usb_kill_urb(dev->urb);

		if (dev->int_buffer)

		usb_free_coherent(dev->udev, YUREX_BUF_SIZE,

				dev->int_buffer, dev->urb->transfer_dma);

		usb_free_urb(dev->urb);