Commit 4d51419d authored by Ilya Maximets's avatar Ilya Maximets Committed by David S. Miller
Browse files

openvswitch: fix send of uninitialized stack memory in ct limit reply 



'struct ovs_zone_limit' has more members than initialized in
ovs_ct_limit_get_default_limit().  The rest of the memory is a random
kernel stack content that ends up being sent to userspace.

Fix that by using designated initializer that will clear all
non-specified fields.

Fixes: 11efd5cb ("openvswitch: Support conntrack zone limit")
Signed-off-by: default avatarIlya Maximets <i.maximets@ovn.org>
Acked-by: default avatarTonghao Zhang <xiangxia.m.yue@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a14d273b

net/openvswitch/conntrack.c

+4 −4
Original line number Diff line number Diff line
@@ -2034,10 +2034,10 @@ static int ovs_ct_limit_del_zone_limit(struct nlattr *nla_zone_limit, 
static int ovs_ct_limit_get_default_limit(struct ovs_ct_limit_info *info,

					  struct sk_buff *reply)

{

	struct ovs_zone_limit zone_limit;



	zone_limit.zone_id = OVS_ZONE_LIMIT_DEFAULT_ZONE;

	zone_limit.limit = info->default_limit;

	struct ovs_zone_limit zone_limit = {

		.zone_id = OVS_ZONE_LIMIT_DEFAULT_ZONE,

		.limit   = info->default_limit,

	};



	return nla_put_nohdr(reply, sizeof(zone_limit), &zone_limit);

}