Commit 4d4c4bff authored by Stefan Binding's avatar Stefan Binding Committed by Takashi Iwai
Browse files

ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties 



For devices which use HID CSC3551, correct ACPI _DSD properties are
required to be able support those systems.
Add error message to clarify this.

Signed-off-by: default avatarStefan Binding <sbinding@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20220815162906.463108-1-sbinding@opensource.cirrus.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 25a3b959

sound/pci/hda/cs35l41_hda.c

+5 −0
Original line number Diff line number Diff line
@@ -1163,6 +1163,11 @@ static int cs35l41_no_acpi_dsd(struct cs35l41_hda *cs35l41, struct device *physd 
		hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH;

		hw_cfg->gpio1.valid = true;

	} else {

		/*

		 * Note: CLSA010(0/1) are special cases which use a slightly different design.

		 * All other HIDs e.g. CSC3551 require valid ACPI _DSD properties to be supported.

		 */

		dev_err(cs35l41->dev, "Error: ACPI _DSD Properties are missing for HID %s.\n", hid);

		hw_cfg->valid = false;

		hw_cfg->gpio1.valid = false;

		hw_cfg->gpio2.valid = false;