Commit 4d471563 authored by Sakari Ailus's avatar Sakari Ailus Committed by Mauro Carvalho Chehab
Browse files

media: i2c: Fix pm_runtime_get_if_in_use() usage in sensor drivers 



pm_runtime_get_if_in_use() returns -EINVAL if runtime PM is disabled. This
should not be considered an error. Generally the driver has enabled
runtime PM already so getting this error due to runtime PM being disabled
will not happen.

Instead of checking for lesser or equal to zero, check for zero only.
Address this for drivers where this pattern exists.

This patch has been produced using the following command:

$ git grep -l pm_runtime_get_if_in_use -- drivers/media/i2c/ | \
  xargs perl -i -pe 's/(pm_runtime_get_if_in_use\(.*\)) \<\= 0/!$1/'

Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: default avatarTomasz Figa <tfiga@chromium.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent d508fffb

drivers/media/i2c/ov13858.c

+1 −1
Original line number Diff line number Diff line
@@ -1230,7 +1230,7 @@ static int ov13858_set_ctrl(struct v4l2_ctrl *ctrl) 
	 * Applying V4L2 control value only happens

	 * when power is up for streaming

	 */

	if (pm_runtime_get_if_in_use(&client->dev) <= 0)

	if (!pm_runtime_get_if_in_use(&client->dev))

		return 0;



	ret = 0;

drivers/media/i2c/ov2685.c

+1 −1
Original line number Diff line number Diff line
@@ -549,7 +549,7 @@ static int ov2685_set_ctrl(struct v4l2_ctrl *ctrl) 
		break;

	}



	if (pm_runtime_get_if_in_use(&client->dev) <= 0)

	if (!pm_runtime_get_if_in_use(&client->dev))

		return 0;



	switch (ctrl->id) {

drivers/media/i2c/ov5670.c

+1 −1
Original line number Diff line number Diff line
@@ -2016,7 +2016,7 @@ static int ov5670_set_ctrl(struct v4l2_ctrl *ctrl) 
	}



	/* V4L2 controls values will be applied only when power is already up */

	if (pm_runtime_get_if_in_use(&client->dev) <= 0)

	if (!pm_runtime_get_if_in_use(&client->dev))

		return 0;



	switch (ctrl->id) {

drivers/media/i2c/ov5695.c

+1 −1
Original line number Diff line number Diff line
@@ -1110,7 +1110,7 @@ static int ov5695_set_ctrl(struct v4l2_ctrl *ctrl) 
		break;

	}



	if (pm_runtime_get_if_in_use(&client->dev) <= 0)

	if (!pm_runtime_get_if_in_use(&client->dev))

		return 0;



	switch (ctrl->id) {

drivers/media/i2c/ov7740.c

+1 −1
Original line number Diff line number Diff line
@@ -510,7 +510,7 @@ static int ov7740_set_ctrl(struct v4l2_ctrl *ctrl) 
	int ret;

	u8 val = 0;



	if (pm_runtime_get_if_in_use(&client->dev) <= 0)

	if (!pm_runtime_get_if_in_use(&client->dev))

		return 0;



	switch (ctrl->id) {