Commit 4d3d3a1b authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski
Browse files

stmmac: dwmac-mediatek: fix resource leak in probe 



If mediatek_dwmac_clks_config() fails, then call stmmac_remove_config_dt()
before returning.  Otherwise it is a resource leak.

Fixes: fa4b3ca6 ("stmmac: dwmac-mediatek: fix clock issue")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YuJ4aZyMUlG6yGGa@kili


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 85f0173d

drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c

+5 −4
Original line number Diff line number Diff line
@@ -688,18 +688,19 @@ static int mediatek_dwmac_probe(struct platform_device *pdev) 


	ret = mediatek_dwmac_clks_config(priv_plat, true);

	if (ret)

		return ret;

		goto err_remove_config_dt;



	ret = stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res);

	if (ret) {

		stmmac_remove_config_dt(pdev, plat_dat);

	if (ret)

		goto err_drv_probe;

	}



	return 0;



err_drv_probe:

	mediatek_dwmac_clks_config(priv_plat, false);

err_remove_config_dt:

	stmmac_remove_config_dt(pdev, plat_dat);



	return ret;

}