Commit 4cf16b6b authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Bjorn Andersson
Browse files

hwspinlock: omap: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarBaolin Wang <baolin.wang@linux.alibaba.com>
Link: https://lore.kernel.org/r/20230314180100.2865801-2-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 72a3a509

drivers/hwspinlock/omap_hwspinlock.c

+3 −5
Original line number Diff line number Diff line
@@ -145,7 +145,7 @@ static int omap_hwspinlock_probe(struct platform_device *pdev) 
	return ret;

}



static int omap_hwspinlock_remove(struct platform_device *pdev)

static void omap_hwspinlock_remove(struct platform_device *pdev)

{

	struct hwspinlock_device *bank = platform_get_drvdata(pdev);

	int ret;
@@ -153,12 +153,10 @@ static int omap_hwspinlock_remove(struct platform_device *pdev) 
	ret = hwspin_lock_unregister(bank);

	if (ret) {

		dev_err(&pdev->dev, "%s failed: %d\n", __func__, ret);

		return 0;

		return;

	}



	pm_runtime_disable(&pdev->dev);



	return 0;

}



static const struct of_device_id omap_hwspinlock_of_match[] = {
@@ -171,7 +169,7 @@ MODULE_DEVICE_TABLE(of, omap_hwspinlock_of_match); 


static struct platform_driver omap_hwspinlock_driver = {

	.probe		= omap_hwspinlock_probe,

	.remove		= omap_hwspinlock_remove,

	.remove_new	= omap_hwspinlock_remove,

	.driver		= {

		.name	= "omap_hwspinlock",

		.of_match_table = omap_hwspinlock_of_match,