Commit 4cc7faa4 authored by Dan Carpenter's avatar Dan Carpenter Committed by Marc Kleine-Budde
Browse files

can: mcp251xfd: mcp251xfd_probe(): fix an error pointer dereference in probe 

When we converted this code to use dev_err_probe() we accidentally
removed a return. It means that if devm_clk_get() it will lead to an
Oops when we call clk_get_rate() on the next line.

Fixes: cf8ee6de ("can: mcp251xfd: mcp251xfd_probe(): use dev_err_probe() to simplify error handling")
Link: https://lore.kernel.org/r/YJANZf13Qxd5Mhr1@mwanda


Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarManivannan Sadhasivam <mani@kernel.org>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 86214366

drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c

+2 −2
Original line number Diff line number Diff line
@@ -2885,7 +2885,7 @@ static int mcp251xfd_probe(struct spi_device *spi) 


	clk = devm_clk_get(&spi->dev, NULL);

	if (IS_ERR(clk))

		dev_err_probe(&spi->dev, PTR_ERR(clk),

		return dev_err_probe(&spi->dev, PTR_ERR(clk),

				     "Failed to get Oscillator (clock)!\n");

	freq = clk_get_rate(clk);