Commit 4cbf0550 authored by Linus Lüssing's avatar Linus Lüssing Committed by Simon Wunderlich
Browse files

batman-adv: bcast: avoid skb-copy for (re)queued broadcasts 



Broadcast packets send via batadv_send_outstanding_bcast_packet() were
originally copied in batadv_forw_bcast_packet_to_list() before being
queued. And after that only the ethernet header will be pushed through
batadv_send_broadcast_skb()->batadv_send_skb_packet() which works safely
on skb clones as it uses batadv_skb_head_push()->skb_cow_head().

Signed-off-by: default avatarLinus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent 3f693390

net/batman-adv/send.c

+1 −1
Original line number Diff line number Diff line
@@ -1072,7 +1072,7 @@ static void batadv_send_outstanding_bcast_packet(struct work_struct *work) 
	}



	/* send a copy of the saved skb */

	skb1 = skb_copy(forw_packet->skb, GFP_ATOMIC);

	skb1 = skb_clone(forw_packet->skb, GFP_ATOMIC);

	if (!skb1)

		goto out;