Commit 4cbbe2aa authored by Zhang Qilong's avatar Zhang Qilong Committed by Mauro Carvalho Chehab
Browse files

media: staging: rkisp1: cap: fix runtime PM imbalance on error 



pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference imbalance in rkisp1_vb2_start_streaming, so we
should fix it.

Fixes: 56e3b29f ("media: staging: rkisp1: add streaming paths")
Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 652ce676

drivers/staging/media/rkisp1/rkisp1-capture.c

+1 −0
Original line number Diff line number Diff line
@@ -1005,6 +1005,7 @@ rkisp1_vb2_start_streaming(struct vb2_queue *queue, unsigned int count) 


	ret = pm_runtime_get_sync(cap->rkisp1->dev);

	if (ret < 0) {

		pm_runtime_put_noidle(cap->rkisp1->dev);

		dev_err(cap->rkisp1->dev, "power up failed %d\n", ret);

		goto err_destroy_dummy;

	}