Commit 4ca446b1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Leon Romanovsky
Browse files

iw_cxgb4: Fix potential NULL dereference in c4iw_fill_res_cm_id_entry() 



This condition needs to match the previous "if (epcp->state == LISTEN) {"
exactly to avoid a NULL dereference of either "listen_ep" or "ep". The
problem is that "epcp" has been re-assigned so just testing
"if (epcp->state == LISTEN) {" a second time is not sufficient.

Fixes: 116aeb88 ("iw_cxgb4: provide detailed provider-specific CM_ID information")
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/Y+usKuWIKr4dimZh@kili


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 50a542a8

drivers/infiniband/hw/cxgb4/restrack.c

+1 −1
Original line number Diff line number Diff line
@@ -238,7 +238,7 @@ int c4iw_fill_res_cm_id_entry(struct sk_buff *msg, 
	if (rdma_nl_put_driver_u64_hex(msg, "history", epcp->history))

		goto err_cancel_table;



	if (epcp->state == LISTEN) {

	if (listen_ep) {

		if (rdma_nl_put_driver_u32(msg, "stid", listen_ep->stid))

			goto err_cancel_table;

		if (rdma_nl_put_driver_u32(msg, "backlog", listen_ep->backlog))