Commit 4c9dbf86 authored by Mario Limonciello's avatar Mario Limonciello Committed by Hans de Goede
Browse files

platform/x86: amd-pmc: adjust arguments for `amd_pmc_send_cmd` 



Currently the "argument" for the "message" is listed as a boolean
value.  This works well for the commands used currently, but an
additional upcoming command will pass more data in the message.

Expand it to be a full 32 bit value.

Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20211020162946.10537-1-mario.limonciello@amd.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 86af1d02

drivers/platform/x86/amd-pmc.c

+3 −3
Original line number Diff line number Diff line
@@ -126,7 +126,7 @@ struct amd_pmc_dev { 
};



static struct amd_pmc_dev pmc;

static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, bool set, u32 *data, u8 msg, bool ret);

static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, u32 arg, u32 *data, u8 msg, bool ret);



static inline u32 amd_pmc_reg_read(struct amd_pmc_dev *dev, int reg_offset)

{
@@ -337,7 +337,7 @@ static void amd_pmc_dump_registers(struct amd_pmc_dev *dev) 
	dev_dbg(dev->dev, "AMD_PMC_REGISTER_MESSAGE:%x\n", value);

}



static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, bool set, u32 *data, u8 msg, bool ret)

static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, u32 arg, u32 *data, u8 msg, bool ret)

{

	int rc;

	u32 val;
@@ -356,7 +356,7 @@ static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, bool set, u32 *data, u8 msg 
	amd_pmc_reg_write(dev, AMD_PMC_REGISTER_RESPONSE, 0);



	/* Write argument into response register */

	amd_pmc_reg_write(dev, AMD_PMC_REGISTER_ARGUMENT, set);

	amd_pmc_reg_write(dev, AMD_PMC_REGISTER_ARGUMENT, arg);



	/* Write message ID to message ID register */

	amd_pmc_reg_write(dev, AMD_PMC_REGISTER_MESSAGE, msg);