Unverified Commit 4c668630 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

regulator: bd71828: Fix .n_voltages settings 



Current .n_voltages settings do not cover the latest 2 valid selectors,
so it fails to set voltage for the hightest voltage support.
The latest linear range has step_uV = 0, so it does not matter if we
count the .n_voltages to maximum selector + 1 or the first selector of
latest linear range + 1.
To simplify calculating the n_voltages, let's just set the
.n_voltages to maximum selector + 1.

Fixes: 522498f8 ("regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators")
Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Reviewed-by: default avatarMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Link: https://lore.kernel.org/r/20210523071045.2168904-2-axel.lin@ingics.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0514582a

include/linux/mfd/rohm-bd71828.h

+5 −5
Original line number Diff line number Diff line
@@ -26,11 +26,11 @@ enum { 
	BD71828_REGULATOR_AMOUNT,

};



#define BD71828_BUCK1267_VOLTS		0xEF

#define BD71828_BUCK3_VOLTS		0x10

#define BD71828_BUCK4_VOLTS		0x20

#define BD71828_BUCK5_VOLTS		0x10

#define BD71828_LDO_VOLTS		0x32

#define BD71828_BUCK1267_VOLTS		0x100

#define BD71828_BUCK3_VOLTS		0x20

#define BD71828_BUCK4_VOLTS		0x40

#define BD71828_BUCK5_VOLTS		0x20

#define BD71828_LDO_VOLTS		0x40

/* LDO6 is fixed 1.8V voltage */

#define BD71828_LDO_6_VOLTAGE		1800000