Commit 4c2e9ba0 authored by Tudor Ambarus's avatar Tudor Ambarus Committed by Vinod Koul
Browse files

dmaengine: at_hdmac: Do not print messages on console while holding the lock 



The descriptor was already removed from the transfer list, there's no
reason to keep the channel lock while printing desc info, thus do the
prints without holding the lock.

Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20221025090306.297886-1-tudor.ambarus@microchip.com
Link: https://lore.kernel.org/r/20221025090306.297886-17-tudor.ambarus@microchip.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 3f134c95

drivers/dma/at_hdmac.c

+2 −2
Original line number Diff line number Diff line
@@ -549,6 +549,8 @@ static void atc_handle_error(struct at_dma_chan *atchan) 
		atc_dostart(atchan, desc);

	}



	spin_unlock_irqrestore(&atchan->lock, flags);



	/*

	 * KERN_CRITICAL may seem harsh, but since this only happens

	 * when someone submits a bad physical address in a
@@ -564,8 +566,6 @@ static void atc_handle_error(struct at_dma_chan *atchan) 
	list_for_each_entry(child, &bad_desc->tx_list, desc_node)

		atc_dump_lli(atchan, &child->lli);



	spin_unlock_irqrestore(&atchan->lock, flags);



	/* Pretend the descriptor completed successfully */

	atc_chain_complete(atchan, bad_desc);

}