Commit 4bdcb8d2 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai
Browse files

ALSA: fireface: pick up time stamp for request subaction of asynchronous transaction 



The time stamp of isochronous cycle at which asynchronous transaction is
sent is perhaps useful somehow. A commit b2405aa9 ("firewire: add
kernel API to access packet structure in request structure for AR context")
adds kernel API to retrieve the time stamp in inner structure of request
subaction.

This commit changes local framework to handle message delivered by the
asynchronous transaction so that time stamp is picked up by the kernel API.

Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20230112120954.500692-3-o-takashi@sakamocchi.jp


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 50c597c7

sound/firewire/fireface/ff-protocol-former.c

+2 −2
Original line number Diff line number Diff line
@@ -403,7 +403,7 @@ static void ff800_finish_session(struct snd_ff *ff) 
// A write transaction to clear registered higher 4 bytes of destination address

// has an effect to suppress asynchronous transaction from device.

static void ff800_handle_midi_msg(struct snd_ff *ff, unsigned int offset, const __le32 *buf,

				  size_t length)

				  size_t length, u32 tstamp)

{

	int i;
@@ -554,7 +554,7 @@ static void ff400_finish_session(struct snd_ff *ff) 
// in its lower offset and expects userspace application to configure the

// register for it.

static void ff400_handle_msg(struct snd_ff *ff, unsigned int offset, const __le32 *buf,

			     size_t length)

			     size_t length, u32 tstamp)

{

	int i;

sound/firewire/fireface/ff-protocol-latter.c

+1 −1
Original line number Diff line number Diff line
@@ -394,7 +394,7 @@ static void latter_dump_status(struct snd_ff *ff, struct snd_info_buffer *buffer 
// (0x'....'....'0000'0000) and expects userspace application to configure the

// register for it.

static void latter_handle_midi_msg(struct snd_ff *ff, unsigned int offset, const __le32 *buf,

				   size_t length)

				   size_t length, u32 tstamp)

{

	u32 data = le32_to_cpu(*buf);

	unsigned int index = (data & 0x000000f0) >> 4;

sound/firewire/fireface/ff-transaction.c

+2 −1
Original line number Diff line number Diff line
@@ -131,11 +131,12 @@ static void handle_msg(struct fw_card *card, struct fw_request *request, int tco 
{

	struct snd_ff *ff = callback_data;

	__le32 *buf = data;

	u32 tstamp = fw_request_get_timestamp(request);



	fw_send_response(card, request, RCODE_COMPLETE);



	offset -= ff->async_handler.offset;

	ff->spec->protocol->handle_msg(ff, (unsigned int)offset, buf, length);

	ff->spec->protocol->handle_msg(ff, (unsigned int)offset, buf, length, tstamp);

}



static int allocate_own_address(struct snd_ff *ff, int i)

sound/firewire/fireface/ff.h

+1 −1
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ enum snd_ff_clock_src { 


struct snd_ff_protocol {

	void (*handle_msg)(struct snd_ff *ff, unsigned int offset, const __le32 *buf,

			   size_t length);

			   size_t length, u32 tstamp);

	int (*fill_midi_msg)(struct snd_ff *ff,

			     struct snd_rawmidi_substream *substream,

			     unsigned int port);