Commit 4bd442e9 authored by Qinglang Miao's avatar Qinglang Miao Committed by Borislav Petkov
Browse files

RAS/CEC: Convert to DEFINE_SHOW_ATTRIBUTE() 



Use the DEFINE_SHOW_ATTRIBUTE() macro and simplify the code.

Signed-off-by: default avatarQinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200919012252.171437-1-miaoqinglang@huawei.com
parent e1007770

drivers/ras/cec.c

+3 −14
Original line number Diff line number Diff line
@@ -435,7 +435,7 @@ DEFINE_DEBUGFS_ATTRIBUTE(action_threshold_ops, u64_get, action_threshold_set, "% 


static const char * const bins[] = { "00", "01", "10", "11" };



static int array_dump(struct seq_file *m, void *v)

static int array_show(struct seq_file *m, void *v)

{

	struct ce_array *ca = &ce_arr;

	int i;
@@ -467,18 +467,7 @@ static int array_dump(struct seq_file *m, void *v) 
	return 0;

}



static int array_open(struct inode *inode, struct file *filp)

{

	return single_open(filp, array_dump, NULL);

}



static const struct file_operations array_ops = {

	.owner	 = THIS_MODULE,

	.open	 = array_open,

	.read	 = seq_read,

	.llseek	 = seq_lseek,

	.release = single_release,

};

DEFINE_SHOW_ATTRIBUTE(array);



static int __init create_debugfs_nodes(void)

{
@@ -513,7 +502,7 @@ static int __init create_debugfs_nodes(void) 
		goto err;

	}



	array = debugfs_create_file("array", S_IRUSR, d, NULL, &array_ops);

	array = debugfs_create_file("array", S_IRUSR, d, NULL, &array_fops);

	if (!array) {

		pr_warn("Error creating array debugfs node!\n");

		goto err;