Commit 4b9c9358 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski
Browse files

net: dsa: dsa_legacy_fdb_{add,del} can be static 



Introduced in commit 37b8da1a ("net: dsa: Move FDB add/del
implementation inside DSA") in net/dsa/legacy.c, these functions were
moved again to slave.c as part of commit 2a93c1a3 ("net: dsa: Allow
compiling out legacy support"), before actually deleting net/dsa/slave.c
in 93e86b3b ("net: dsa: Remove legacy probing support"). Along with
that movement there should have been a deletion of the prototypes from
dsa_priv.h, they are not useful.

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20210108233054.1222278-1-olteanv@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 430cc484

net/dsa/dsa_priv.h

+0 −9
Original line number Diff line number Diff line
@@ -110,15 +110,6 @@ void dsa_tag_driver_put(const struct dsa_device_ops *ops); 
bool dsa_schedule_work(struct work_struct *work);

const char *dsa_tag_protocol_to_str(const struct dsa_device_ops *ops);



int dsa_legacy_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],

		       struct net_device *dev,

		       const unsigned char *addr, u16 vid,

		       u16 flags,

		       struct netlink_ext_ack *extack);

int dsa_legacy_fdb_del(struct ndmsg *ndm, struct nlattr *tb[],

		       struct net_device *dev,

		       const unsigned char *addr, u16 vid);



/* master.c */

int dsa_master_setup(struct net_device *dev, struct dsa_port *cpu_dp);

void dsa_master_teardown(struct net_device *dev);

net/dsa/slave.c

+8 −8
Original line number Diff line number Diff line
@@ -1575,7 +1575,7 @@ static const struct ethtool_ops dsa_slave_ethtool_ops = { 
};



/* legacy way, bypassing the bridge *****************************************/

int dsa_legacy_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],

static int dsa_legacy_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],

			      struct net_device *dev,

			      const unsigned char *addr, u16 vid,

			      u16 flags,
@@ -1586,7 +1586,7 @@ int dsa_legacy_fdb_add(struct ndmsg *ndm, struct nlattr *tb[], 
	return dsa_port_fdb_add(dp, addr, vid);

}



int dsa_legacy_fdb_del(struct ndmsg *ndm, struct nlattr *tb[],

static int dsa_legacy_fdb_del(struct ndmsg *ndm, struct nlattr *tb[],

			      struct net_device *dev,

			      const unsigned char *addr, u16 vid)

{