Commit 4b95391c authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

serial: 8250_pci: remove redundant assignment to tmp after the mask operation 



The variable tmp is being masked with a bitmask and the value is being
written to port base + 0x3c.  However, the masked value is being written
back to tmp and tmp is never used after this. The assignmentment is
redundant, replace the &= operator with just &.

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Reviewesd-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20211205232822.110099-1-colin.i.king@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e5ce127e

drivers/tty/serial/8250/8250_pci.c

+1 −1
Original line number Diff line number Diff line
@@ -1278,7 +1278,7 @@ static int pci_quatech_init(struct pci_dev *dev) 
			outl(inl(base + 0x38) | 0x00002000, base + 0x38);

			tmp = inl(base + 0x3c);

			outl(tmp | 0x01000000, base + 0x3c);

			outl(tmp &= ~0x01000000, base + 0x3c);

			outl(tmp & ~0x01000000, base + 0x3c);

		}

	}

	return 0;