Commit 4b70dce2 authored Oct 10, 2021 by Juhee Kang Committed by David S. Miller Oct 10, 2021

bnxt: use netif_is_rxfh_configured instead of open code

The open code which is dev->priv_flags & IFF_RXFH_CONFIGURED is defined as
a helper function on netdevice.h. So use netif_is_rxfh_configured()
function instead of open code. This patch doesn't change logic.

Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 154ee116

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6366,7 +6366,7 @@ static int __bnxt_reserve_rings(struct bnxt *bp)
		if (rx_rings != bp->rx_nr_rings) {
		netdev_warn(bp->dev, "Able to reserve only %d out of %d requested RX rings\n",
		rx_rings, bp->rx_nr_rings);
		if ((bp->dev->priv_flags & IFF_RXFH_CONFIGURED) &&
		if (netif_is_rxfh_configured(bp->dev) &&
		(bnxt_get_nr_rss_ctxs(bp, bp->rx_nr_rings) !=
		bnxt_get_nr_rss_ctxs(bp, rx_rings) \|\|
		bnxt_get_max_rss_ring(bp) >= rx_rings)) {

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -909,7 +909,7 @@ static int bnxt_set_channels(struct net_device *dev,

		if (bnxt_get_nr_rss_ctxs(bp, req_rx_rings) !=
		bnxt_get_nr_rss_ctxs(bp, bp->rx_nr_rings) &&
		(dev->priv_flags & IFF_RXFH_CONFIGURED)) {
		netif_is_rxfh_configured(dev)) {
		netdev_warn(dev, "RSS table size change required, RSS table entries must be default to proceed\n");
		return -EINVAL;
		}