Commit 4b672eb7 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Remove dead TPS3->TPS2 fallback code 



If we ever get here with TPS3 then intel_dp_training_pattern()
is just broken. Replace the careful fallback with just
MISSING_CASE().

Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210318161015.22070-2-ville.syrjala@linux.intel.com
parent 1663ad49

drivers/gpu/drm/i915/display/intel_dp.c

+6 −10
Original line number Diff line number Diff line
@@ -2503,11 +2503,9 @@ cpt_set_link_train(struct intel_dp *intel_dp, 
	case DP_TRAINING_PATTERN_2:

		*DP |= DP_LINK_TRAIN_PAT_2_CPT;

		break;

	case DP_TRAINING_PATTERN_3:

		drm_dbg_kms(&dev_priv->drm,

			    "TPS3 not supported, using TPS2 instead\n");

		*DP |= DP_LINK_TRAIN_PAT_2_CPT;

		break;

	default:

		MISSING_CASE(intel_dp_training_pattern_symbol(dp_train_pat));

		return;

	}



	intel_de_write(dev_priv, intel_dp->output_reg, intel_dp->DP);
@@ -2808,11 +2806,9 @@ g4x_set_link_train(struct intel_dp *intel_dp, 
	case DP_TRAINING_PATTERN_2:

		*DP |= DP_LINK_TRAIN_PAT_2;

		break;

	case DP_TRAINING_PATTERN_3:

		drm_dbg_kms(&dev_priv->drm,

			    "TPS3 not supported, using TPS2 instead\n");

		*DP |= DP_LINK_TRAIN_PAT_2;

		break;

	default:

		MISSING_CASE(intel_dp_training_pattern_symbol(dp_train_pat));

		return;

	}



	intel_de_write(dev_priv, intel_dp->output_reg, intel_dp->DP);