Commit 4b5305de authored by Peter Zijlstra's avatar Peter Zijlstra
Browse files

x86/extable: Extend extable functionality 

In order to remove further .fixup usage, extend the extable
infrastructure to take additional information from the extable entry
sites.

Specifically add _ASM_EXTABLE_TYPE_REG() and EX_TYPE_IMM_REG that
extend the existing _ASM_EXTABLE_TYPE() by taking an additional
register argument and encoding that and an s16 immediate into the
existing s32 type field. This limits the actual types to the first
byte, 255 seem plenty.

Also add a few flags into the type word, specifically CLEAR_AX and
CLEAR_DX which clear the return and extended return register.

Notes:
 - due to the % in our register names it's hard to make it more
   generally usable as arm64 did.
 - the s16 is far larger than used in these patches, future extentions
   can easily shrink this to get more bits.
 - without the bitfield fix this will not compile, because: 0xFF > -1
   and we can't even extract the TYPE field.

[nathanchance: Build fix for clang-lto builds:
 https://lkml.kernel.org/r/20211210234953.3420108-1-nathan@kernel.org


]

Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Tested-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Link: https://lore.kernel.org/r/20211110101325.303890153@infradead.org
parent aa93e2ad

arch/x86/include/asm/asm.h

+37 −0
Original line number Diff line number Diff line
@@ -152,6 +152,33 @@ 


#else /* ! __ASSEMBLY__ */



# define DEFINE_EXTABLE_TYPE_REG \

	".macro extable_type_reg type:req reg:req\n"						\

	".set found, 0\n"									\

	".set regnr, 0\n"									\

	".irp rs,rax,rcx,rdx,rbx,rsp,rbp,rsi,rdi,r8,r9,r10,r11,r12,r13,r14,r15\n"		\

	".ifc \\reg, %%\\rs\n"									\

	".set found, found+1\n"									\

	".long \\type + (regnr << 8)\n"								\

	".endif\n"										\

	".set regnr, regnr+1\n"									\

	".endr\n"										\

	".set regnr, 0\n"									\

	".irp rs,eax,ecx,edx,ebx,esp,ebp,esi,edi,r8d,r9d,r10d,r11d,r12d,r13d,r14d,r15d\n"	\

	".ifc \\reg, %%\\rs\n"									\

	".set found, found+1\n"									\

	".long \\type + (regnr << 8)\n"								\

	".endif\n"										\

	".set regnr, regnr+1\n"									\

	".endr\n"										\

	".if (found != 1)\n"									\

	".error \"extable_type_reg: bad register argument\"\n"					\

	".endif\n"										\

	".endm\n"



# define UNDEFINE_EXTABLE_TYPE_REG \

	".purgem extable_type_reg\n"



# define _ASM_EXTABLE_TYPE(from, to, type)			\

	" .pushsection \"__ex_table\",\"a\"\n"			\

	" .balign 4\n"						\
@@ -160,6 +187,16 @@ 
	" .long " __stringify(type) " \n"			\

	" .popsection\n"



# define _ASM_EXTABLE_TYPE_REG(from, to, type, reg)				\

	" .pushsection \"__ex_table\",\"a\"\n"					\

	" .balign 4\n"								\

	" .long (" #from ") - .\n"						\

	" .long (" #to ") - .\n"						\

	DEFINE_EXTABLE_TYPE_REG							\

	"extable_type_reg reg=" __stringify(reg) ", type=" __stringify(type) " \n"\

	UNDEFINE_EXTABLE_TYPE_REG						\

	" .popsection\n"



/* For C file, we already have NOKPROBE_SYMBOL macro */



/*

arch/x86/include/asm/extable.h

+3 −3
Original line number Diff line number Diff line
@@ -21,7 +21,7 @@ 
 */



struct exception_table_entry {

	int insn, fixup, type;

	int insn, fixup, data;

};

struct pt_regs;
@@ -31,8 +31,8 @@ struct pt_regs; 
	do {							\

		(a)->fixup = (b)->fixup + (delta);		\

		(b)->fixup = (tmp).fixup - (delta);		\

		(a)->type = (b)->type;				\

		(b)->type = (tmp).type;				\

		(a)->data = (b)->data;				\

		(b)->data = (tmp).data;				\

	} while (0)



extern int fixup_exception(struct pt_regs *regs, int trapnr,

arch/x86/include/asm/extable_fixup_types.h

+24 −0
Original line number Diff line number Diff line
@@ -2,6 +2,29 @@ 
#ifndef _ASM_X86_EXTABLE_FIXUP_TYPES_H

#define _ASM_X86_EXTABLE_FIXUP_TYPES_H



/*

 * Our IMM is signed, as such it must live at the top end of the word. Also,

 * since C99 hex constants are of ambigious type, force cast the mask to 'int'

 * so that FIELD_GET() will DTRT and sign extend the value when it extracts it.

 */

#define EX_DATA_TYPE_MASK		((int)0x000000FF)

#define EX_DATA_REG_MASK		((int)0x00000F00)

#define EX_DATA_FLAG_MASK		((int)0x0000F000)

#define EX_DATA_IMM_MASK		((int)0xFFFF0000)



#define EX_DATA_REG_SHIFT		8

#define EX_DATA_FLAG_SHIFT		12

#define EX_DATA_IMM_SHIFT		16



#define EX_DATA_FLAG(flag)		((flag) << EX_DATA_FLAG_SHIFT)

#define EX_DATA_IMM(imm)		((imm) << EX_DATA_IMM_SHIFT)



/* flags */

#define EX_FLAG_CLEAR_AX		EX_DATA_FLAG(1)

#define EX_FLAG_CLEAR_DX		EX_DATA_FLAG(2)

#define EX_FLAG_CLEAR_AX_DX		EX_DATA_FLAG(3)



/* types */

#define	EX_TYPE_NONE			 0

#define	EX_TYPE_DEFAULT			 1

#define	EX_TYPE_FAULT			 2
@@ -20,5 +43,6 @@ 
#define	EX_TYPE_FAULT_MCE_SAFE		13



#define	EX_TYPE_POP_ZERO		14

#define	EX_TYPE_IMM_REG			15 /* reg := (long)imm */



#endif

arch/x86/include/asm/insn-eval.h

+2 −0
Original line number Diff line number Diff line
@@ -15,6 +15,8 @@ 
#define INSN_CODE_SEG_OPND_SZ(params) (params & 0xf)

#define INSN_CODE_SEG_PARAMS(oper_sz, addr_sz) (oper_sz | (addr_sz << 4))



int pt_regs_offset(struct pt_regs *regs, int regno);



bool insn_has_rep_prefix(struct insn *insn);

void __user *insn_get_addr_ref(struct insn *insn, struct pt_regs *regs);

int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs);

arch/x86/lib/insn-eval.c

+42 −24
Original line number Diff line number Diff line
@@ -412,12 +412,7 @@ static short get_segment_selector(struct pt_regs *regs, int seg_reg_idx) 
#endif /* CONFIG_X86_64 */

}



static int get_reg_offset(struct insn *insn, struct pt_regs *regs,

			  enum reg_type type)

{

	int regno = 0;



	static const int regoff[] = {

static const int pt_regoff[] = {

	offsetof(struct pt_regs, ax),

	offsetof(struct pt_regs, cx),

	offsetof(struct pt_regs, dx),
@@ -437,7 +432,19 @@ static int get_reg_offset(struct insn *insn, struct pt_regs *regs, 
	offsetof(struct pt_regs, r15),

#endif

};

	int nr_registers = ARRAY_SIZE(regoff);



int pt_regs_offset(struct pt_regs *regs, int regno)

{

	if ((unsigned)regno < ARRAY_SIZE(pt_regoff))

		return pt_regoff[regno];

	return -EDOM;

}



static int get_regno(struct insn *insn, enum reg_type type)

{

	int nr_registers = ARRAY_SIZE(pt_regoff);

	int regno = 0;



	/*

	 * Don't possibly decode a 32-bit instructions as

	 * reading a 64-bit-only register.
@@ -505,7 +512,18 @@ static int get_reg_offset(struct insn *insn, struct pt_regs *regs, 
		WARN_ONCE(1, "decoded an instruction with an invalid register");

		return -EINVAL;

	}

	return regoff[regno];

	return regno;

}



static int get_reg_offset(struct insn *insn, struct pt_regs *regs,

			  enum reg_type type)

{

	int regno = get_regno(insn, type);



	if (regno < 0)

		return regno;



	return pt_regs_offset(regs, regno);

}



/**