Commit 4b3ed1ae authored by Cai Huoqing's avatar Cai Huoqing Committed by Dmitry Torokhov
Browse files

Input: raydium_i2c_ts - make use of the helper function devm_add_action_or_reset() 



The helper function devm_add_action_or_reset() will internally
call devm_add_action(), and if devm_add_action() fails then it will
execute the action mentioned and return the error code. So
use devm_add_action_or_reset() instead of devm_add_action()
to simplify the error handling, reduce the code.

Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210922125212.95-3-caihuoqing@baidu.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent b083704f

drivers/input/touchscreen/raydium_i2c_ts.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -1118,11 +1118,11 @@ static int raydium_i2c_probe(struct i2c_client *client, 
	if (error)

	if (error)

		return error;

		return error;





	error = devm_add_action(&client->dev, raydium_i2c_power_off, ts);

	error = devm_add_action_or_reset(&client->dev,

					 raydium_i2c_power_off, ts);

	if (error) {

	if (error) {

		dev_err(&client->dev,

		dev_err(&client->dev,

			"failed to install power off action: %d\n", error);

			"failed to install power off action: %d\n", error);

		raydium_i2c_power_off(ts);

		return error;

		return error;

	}

	}