Commit 4b081ce0 authored by Namjae Jeon's avatar Namjae Jeon Committed by Steve French
Browse files

ksmbd: fix slub overflow in ksmbd_decode_ntlmssp_auth_blob() 



If authblob->SessionKey.Length is bigger than session key
size(CIFS_KEY_SIZE), slub overflow can happen in key exchange codes.
cifs_arc4_crypt copy to session key array from SessionKey from client.

Cc: stable@vger.kernel.org
Reported-by: zdi-disclosures@trendmicro.com # ZDI-CAN-21940
Signed-off-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 17d5b135

fs/smb/server/auth.c

+3 −0
Original line number Diff line number Diff line
@@ -355,6 +355,9 @@ int ksmbd_decode_ntlmssp_auth_blob(struct authenticate_message *authblob, 
		if (blob_len < (u64)sess_key_off + sess_key_len)

			return -EINVAL;



		if (sess_key_len > CIFS_KEY_SIZE)

			return -EINVAL;



		ctx_arc4 = kmalloc(sizeof(*ctx_arc4), GFP_KERNEL);

		if (!ctx_arc4)

			return -ENOMEM;