Commit 4ad6429d authored by Mike Marciniszyn's avatar Mike Marciniszyn Committed by Jason Gunthorpe
Browse files

IB/rdmavt: Correct comments in rdmavt_qp.h header 

Comments need to be with the definition of rvt_restart_sge().

Other comments were duplicated in sw/rdmavt/rc.c and were removed.

Fixes: 385156c5 ("IB/hfi: Move RC functions into a header file")
Link: https://lore.kernel.org/r/20191219211934.58387.88014.stgit@awfm-01.aw.intel.com


Reviewed-by: default avatarKaike Wan <kaike.wan@intel.com>
Signed-off-by: default avatarMike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 44ec5aa3

drivers/infiniband/sw/rdmavt/rc.c

+8 −1
Original line number Diff line number Diff line
@@ -195,7 +195,14 @@ void rvt_get_credit(struct rvt_qp *qp, u32 aeth) 
}

EXPORT_SYMBOL(rvt_get_credit);



/* rvt_restart_sge - rewind the sge state for a wqe */

/**

 * rvt_restart_sge - rewind the sge state for a wqe

 * @ss: the sge state pointer

 * @wqe: the wqe to rewind

 * @len: the data length from the start of the wqe in bytes

 *

 * Returns the remaining data length.

 */

u32 rvt_restart_sge(struct rvt_sge_state *ss, struct rvt_swqe *wqe, u32 len)

{

	ss->sge = wqe->sg_list[0];

include/rdma/rdmavt_qp.h

+1 −21
Original line number Diff line number Diff line
@@ -640,34 +640,14 @@ static inline int rvt_cmp_msn(u32 a, u32 b) 
	return (((int)a) - ((int)b)) << 8;

}



/**

 * rvt_compute_aeth - compute the AETH (syndrome + MSN)

 * @qp: the queue pair to compute the AETH for

 *

 * Returns the AETH.

 */

__be32 rvt_compute_aeth(struct rvt_qp *qp);



/**

 * rvt_get_credit - flush the send work queue of a QP

 * @qp: the qp who's send work queue to flush

 * @aeth: the Acknowledge Extended Transport Header

 *

 * The QP s_lock should be held.

 */

void rvt_get_credit(struct rvt_qp *qp, u32 aeth);



/**

 * rvt_restart_sge - rewind the sge state for a wqe

 * @ss: the sge state pointer

 * @wqe: the wqe to rewind

 * @len: the data length from the start of the wqe in bytes

 *

 * Returns the remaining data length.

 */

u32 rvt_restart_sge(struct rvt_sge_state *ss, struct rvt_swqe *wqe, u32 len);



/**

 * rvt_div_round_up_mtu - round up divide

 * @qp - the qp pair

 * @len - the length

 *