Commit 4ac7573e authored by Hangyu Hua's avatar Hangyu Hua Committed by Dominique Martinet
Browse files

net: 9p: fix refcount leak in p9_read_work() error handling 

p9_req_put need to be called when m->rreq->rc.sdata is NULL to avoid
temporary refcount leak.

Link: https://lkml.kernel.org/r/20220712104438.30800-1-hbh25y@gmail.com


Fixes: 728356de ("9p: Add refcount to p9_req_t")
Signed-off-by: default avatarHangyu Hua <hbh25y@gmail.com>
[Dominique: commit wording adjustments, p9_req_put argument fixes for rebase]
Signed-off-by: default avatarDominique Martinet <asmadeus@codewreck.org>
parent 67dd8e44

net/9p/trans_fd.c

+1 −0
Original line number Diff line number Diff line
@@ -343,6 +343,7 @@ static void p9_read_work(struct work_struct *work) 
			p9_debug(P9_DEBUG_ERROR,

				 "No recv fcall for tag %d (req %p), disconnecting!\n",

				 m->rc.tag, m->rreq);

			p9_req_put(m->client, m->rreq);

			m->rreq = NULL;

			err = -EIO;

			goto error;