Commit 4abdb72b authored by Nikola Cornij's avatar Nikola Cornij Committed by Alex Deucher
Browse files

drm/amd/display: Add debug out when viewport too small 



[why] It helps debugging display setup issues

Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarNikola Cornij <nikola.cornij@amd.com>
Reviewed-by: default avatarNicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Acked-by: default avatarSolomon Chiu <solomon.chiu@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 1f053689

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+10 −6
Original line number Diff line number Diff line
@@ -6569,15 +6569,19 @@ static int dm_plane_helper_check_state(struct drm_plane_state *state, 
			else if (state->crtc_y + state->crtc_h > new_crtc_state->mode.crtc_vdisplay)

				viewport_height = new_crtc_state->mode.crtc_vdisplay - state->crtc_y;



			/* If completely outside of screen, viewport_width and/or viewport_height will be negative,

			 * which is still OK to satisfy the condition below, thereby also covering these cases

			 * (when plane is completely outside of screen).

			 * x2 for width is because of pipe-split.

			 */

			if (viewport_width < MIN_VIEWPORT_SIZE*2 || viewport_height < MIN_VIEWPORT_SIZE)

			if (viewport_width < 0 || viewport_height < 0) {

				DRM_DEBUG_ATOMIC("Plane completely outside of screen\n");

				return -EINVAL;

			} else if (viewport_width < MIN_VIEWPORT_SIZE*2) { /* x2 for width is because of pipe-split. */

				DRM_DEBUG_ATOMIC("Viewport width %d smaller than %d\n", viewport_width, MIN_VIEWPORT_SIZE*2);

				return -EINVAL;

			} else if (viewport_height < MIN_VIEWPORT_SIZE) {

				DRM_DEBUG_ATOMIC("Viewport height %d smaller than %d\n", viewport_height, MIN_VIEWPORT_SIZE);

				return -EINVAL;

			}



		}



		/* Get min/max allowed scaling factors from plane caps. */

		get_min_max_dc_plane_scaling(state->crtc->dev, fb,

					     &min_downscale, &max_upscale);