Commit 4a1b9f4e authored by Rob Herring's avatar Rob Herring Committed by Bjorn Andersson
Browse files

soc: qcom: Use of_property_present() for testing DT property presence 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230310144724.1545153-1-robh@kernel.org
parent 903caf42

drivers/soc/qcom/qcom_aoss.c

+1 −1
Original line number Diff line number Diff line
@@ -395,7 +395,7 @@ static int qmp_cooling_devices_register(struct qmp *qmp) 
		return -ENOMEM;



	for_each_available_child_of_node(np, child) {

		if (!of_find_property(child, "#cooling-cells", NULL))

		if (!of_property_present(child, "#cooling-cells"))

			continue;

		ret = qmp_cooling_device_add(qmp, &qmp->cooling_devs[count++],

					     child);

drivers/soc/qcom/smem.c

+1 −1
Original line number Diff line number Diff line
@@ -1045,7 +1045,7 @@ static int qcom_smem_probe(struct platform_device *pdev) 
	int i;



	num_regions = 1;

	if (of_find_property(pdev->dev.of_node, "qcom,rpm-msg-ram", NULL))

	if (of_property_present(pdev->dev.of_node, "qcom,rpm-msg-ram"))

		num_regions++;



	array_size = num_regions * sizeof(struct smem_region);

drivers/soc/qcom/smsm.c

+1 −1
Original line number Diff line number Diff line
@@ -510,7 +510,7 @@ static int qcom_smsm_probe(struct platform_device *pdev) 
		return -ENOMEM;



	for_each_child_of_node(pdev->dev.of_node, local_node) {

		if (of_find_property(local_node, "#qcom,smem-state-cells", NULL))

		if (of_property_present(local_node, "#qcom,smem-state-cells"))

			break;

	}

	if (!local_node) {