Commit 49df54a6 authored by David Howells's avatar David Howells
Browse files

rxrpc: Fix call leak 



When retransmitting a packet, rxrpc_resend() shouldn't be attaching a ref
to the call to the txbuf as that pins the call and prevents the call from
clearing the packet buffer.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Fixes: d57a3a15 ("rxrpc: Save last ACK's SACK table rather than marking txbufs")
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
parent 75bfdbf2

net/rxrpc/call_event.c

+0 −1
Original line number Diff line number Diff line
@@ -198,7 +198,6 @@ static void rxrpc_resend(struct rxrpc_call *call, unsigned long now_j) 


			if (list_empty(&txb->tx_link)) {

				rxrpc_get_txbuf(txb, rxrpc_txbuf_get_retrans);

				rxrpc_get_call(call, rxrpc_call_got_tx);

				list_add_tail(&txb->tx_link, &retrans_queue);

				set_bit(RXRPC_TXBUF_RESENT, &txb->flags);

			}