Commit 49d8c5ff authored by Stefano Garzarella's avatar Stefano Garzarella Committed by Michael S. Tsirkin
Browse files

vhost/vsock: fix incorrect used length reported to the guest 



The "used length" reported by calling vhost_add_used() must be the
number of bytes written by the device (using "in" buffers).

In vhost_vsock_handle_tx_kick() the device only reads the guest
buffers (they are all "out" buffers), without writing anything,
so we must pass 0 as "used length" to comply virtio spec.

Fixes: 433fc58e ("VSOCK: Introduce vhost_vsock.ko")
Cc: stable@vger.kernel.org
Reported-by: default avatarHalil Pasic <pasic@linux.ibm.com>
Suggested-by: default avatarJason Wang <jasowang@redhat.com>
Signed-off-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Link: https://lore.kernel.org/r/20211122163525.294024-2-sgarzare@redhat.com


Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: default avatarHalil Pasic <pasic@linux.ibm.com>
parent f124034f

drivers/vhost/vsock.c

+1 −1
Original line number Diff line number Diff line
@@ -554,7 +554,7 @@ static void vhost_vsock_handle_tx_kick(struct vhost_work *work) 
			virtio_transport_free_pkt(pkt);



		len += sizeof(pkt->hdr);

		vhost_add_used(vq, head, len);

		vhost_add_used(vq, head, 0);

		total_len += len;

		added = true;

	} while(likely(!vhost_exceeds_weight(vq, ++pkts, total_len)));