Unverified Commit 49b2b9c1 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!11921 hwmon: (lm95234) Fix underflows seen when writing limit attributes 

Merge Pull Request from: @ci-robot 
 
PR sync from: Xiongfeng Wang <wangxiongfeng2@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/GOLXKJ47JUIINJCKP3YR2H4C7UN7GA4K/ 
 
https://gitee.com/src-openeuler/kernel/issues/IAS0PZ 
 
Link:https://gitee.com/openeuler/kernel/pulls/11921

 

Reviewed-by: default avatarWei Li <liwei391@huawei.com>
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
parents 3a5093f2 ac939d7f

drivers/hwmon/lm95234.c

+5 −4
Original line number Diff line number Diff line
@@ -310,7 +310,8 @@ static ssize_t set_tcrit2(struct device *dev, struct device_attribute *attr, 
	if (ret < 0)

		return ret;



	val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), 0, index ? 255 : 127);

	val = DIV_ROUND_CLOSEST(clamp_val(val, 0, (index ? 255 : 127) * 1000),

				1000);



	mutex_lock(&data->update_lock);

	data->tcrit2[index] = val;
@@ -359,7 +360,7 @@ static ssize_t set_tcrit1(struct device *dev, struct device_attribute *attr, 
	if (ret < 0)

		return ret;



	val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), 0, 255);

	val = DIV_ROUND_CLOSEST(clamp_val(val, 0, 255000), 1000);



	mutex_lock(&data->update_lock);

	data->tcrit1[index] = val;
@@ -400,7 +401,7 @@ static ssize_t set_tcrit1_hyst(struct device *dev, 
	if (ret < 0)

		return ret;



	val = DIV_ROUND_CLOSEST(val, 1000);

	val = DIV_ROUND_CLOSEST(clamp_val(val, -255000, 255000), 1000);

	val = clamp_val((int)data->tcrit1[index] - val, 0, 31);



	mutex_lock(&data->update_lock);
@@ -440,7 +441,7 @@ static ssize_t set_offset(struct device *dev, struct device_attribute *attr, 
		return ret;



	/* Accuracy is 1/2 degrees C */

	val = clamp_val(DIV_ROUND_CLOSEST(val, 500), -128, 127);

	val = DIV_ROUND_CLOSEST(clamp_val(val, -64000, 63500), 500);



	mutex_lock(&data->update_lock);

	data->toffset[index] = val;