Commit 49af6a76 authored by Colin Foster's avatar Colin Foster Committed by Jakub Kicinski
Browse files

net: dsa: ocelot: felix: Remove requirement for PCS in felix devices 



Existing felix devices all have an initialized pcs array. Future devices
might not, so running a NULL check on the array before dereferencing it
will allow those future drivers to not crash at this point

Signed-off-by: default avatarColin Foster <colin.foster@in-advantage.com>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c9910484

drivers/net/dsa/ocelot/felix.c

+1 −1
Original line number Diff line number Diff line
@@ -828,7 +828,7 @@ static void felix_phylink_mac_config(struct dsa_switch *ds, int port, 
	struct felix *felix = ocelot_to_felix(ocelot);

	struct dsa_port *dp = dsa_to_port(ds, port);



	if (felix->pcs[port])

	if (felix->pcs && felix->pcs[port])

		phylink_set_pcs(dp->pl, &felix->pcs[port]->pcs);

}