Commit 49a9565a authored by David Lechner's avatar David Lechner Committed by Jonathan Cameron
Browse files

counter:ti-eqep: remove floor 



The hardware doesn't support this. QPOSINIT is an initialization value
that is triggered by other things. When the counter overflows, it
always wraps around to zero.

Fixes: f213729f "counter: new TI eQEP driver"
Signed-off-by: default avatarDavid Lechner <david@lechnology.com>
Acked-by: default avatarWilliam Breathitt Gray <vilhelm.gray@gmail.com>
Link: https://lore.kernel.org/r/20201214000927.1793062-1-david@lechnology.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent cf5b1385

drivers/counter/ti-eqep.c

+0 −35
Original line number Diff line number Diff line
@@ -235,36 +235,6 @@ static ssize_t ti_eqep_position_ceiling_write(struct counter_device *counter, 
	return len;

}



static ssize_t ti_eqep_position_floor_read(struct counter_device *counter,

					   struct counter_count *count,

					   void *ext_priv, char *buf)

{

	struct ti_eqep_cnt *priv = counter->priv;

	u32 qposinit;



	regmap_read(priv->regmap32, QPOSINIT, &qposinit);



	return sprintf(buf, "%u\n", qposinit);

}



static ssize_t ti_eqep_position_floor_write(struct counter_device *counter,

					    struct counter_count *count,

					    void *ext_priv, const char *buf,

					    size_t len)

{

	struct ti_eqep_cnt *priv = counter->priv;

	int err;

	u32 res;



	err = kstrtouint(buf, 0, &res);

	if (err < 0)

		return err;



	regmap_write(priv->regmap32, QPOSINIT, res);



	return len;

}



static ssize_t ti_eqep_position_enable_read(struct counter_device *counter,

					    struct counter_count *count,

					    void *ext_priv, char *buf)
@@ -301,11 +271,6 @@ static struct counter_count_ext ti_eqep_position_ext[] = { 
		.read	= ti_eqep_position_ceiling_read,

		.write	= ti_eqep_position_ceiling_write,

	},

	{

		.name	= "floor",

		.read	= ti_eqep_position_floor_read,

		.write	= ti_eqep_position_floor_write,

	},

	{

		.name	= "enable",

		.read	= ti_eqep_position_enable_read,