Commit 49a64c6d authored by Zhu Lingshan's avatar Zhu Lingshan Committed by Michael S. Tsirkin
Browse files

vDPA/ifcvf: a vendor driver should not set _CONFIG_S_FAILED 



VIRTIO_CONFIG_S_FAILED indicates the guest driver has given up
the device due to fatal errors. So it is the guest decision,
the vendor driver should not set this status to the device.

Signed-off-by: default avatarZhu Lingshan <lingshan.zhu@intel.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
Message-Id: <20230526145254.39537-6-lingshan.zhu@intel.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 386a2620

drivers/vdpa/ifcvf/ifcvf_main.c

+1 −3
Original line number Diff line number Diff line
@@ -426,9 +426,7 @@ static void ifcvf_vdpa_set_status(struct vdpa_device *vdpa_dev, u8 status) 
	    !(status_old & VIRTIO_CONFIG_S_DRIVER_OK)) {

		ret = ifcvf_request_irq(vf);

		if (ret) {

			status = ifcvf_get_status(vf);

			status |= VIRTIO_CONFIG_S_FAILED;

			ifcvf_set_status(vf, status);

			IFCVF_ERR(vf->pdev, "failed to request irq with error %d\n", ret);

			return;

		}

	}