Commit 496bb184 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Bjorn Helgaas
Browse files

PCI: j721e: Fix j721e_pcie_probe() error path 

If an error occurs after a successful cdns_pcie_init_phy() call, it must be
undone by a cdns_pcie_disable_phy() call, as already done above and below.

Update the goto to branch at the correct place of the error handling path.

Link: https://lore.kernel.org/r/db477b0cb444891a17c4bb424467667dc30d0bab.1624794264.git.christophe.jaillet@wanadoo.fr


Fixes: 49e0efdc ("PCI: j721e: Add support to provide refclk to PCIe connector")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarKrzysztof Wilczyński <kw@linux.com>
parent e4e737bb

drivers/pci/controller/cadence/pci-j721e.c

+1 −1
Original line number Diff line number Diff line
@@ -474,7 +474,7 @@ static int j721e_pcie_probe(struct platform_device *pdev) 
		ret = clk_prepare_enable(clk);

		if (ret) {

			dev_err(dev, "failed to enable pcie_refclk\n");

			goto err_get_sync;

			goto err_pcie_setup;

		}

		pcie->refclk = clk;