Commit 4934fb7d authored by YueHaibing's avatar YueHaibing Committed by David S. Miller
Browse files

sfc: falcon: use DEVICE_ATTR_*() macro 



Use DEVICE_ATTR_*() helper instead of plain DEVICE_ATTR,
which makes the code a bit shorter and easier to read.

Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3880fc37

drivers/net/ethernet/sfc/falcon/efx.c

+2 −2
Original line number Diff line number Diff line
@@ -2254,12 +2254,12 @@ static struct notifier_block ef4_netdev_notifier = { 
};



static ssize_t

show_phy_type(struct device *dev, struct device_attribute *attr, char *buf)

phy_type_show(struct device *dev, struct device_attribute *attr, char *buf)

{

	struct ef4_nic *efx = dev_get_drvdata(dev);

	return sprintf(buf, "%d\n", efx->phy_type);

}

static DEVICE_ATTR(phy_type, 0444, show_phy_type, NULL);

static DEVICE_ATTR_RO(phy_type);



static int ef4_register_netdev(struct ef4_nic *efx)

{

drivers/net/ethernet/sfc/falcon/falcon_boards.c

+5 −5
Original line number Diff line number Diff line
@@ -354,14 +354,14 @@ static int sfe4001_poweron(struct ef4_nic *efx) 
	return rc;

}



static ssize_t show_phy_flash_cfg(struct device *dev,

static ssize_t phy_flash_cfg_show(struct device *dev,

				  struct device_attribute *attr, char *buf)

{

	struct ef4_nic *efx = dev_get_drvdata(dev);

	return sprintf(buf, "%d\n", !!(efx->phy_mode & PHY_MODE_SPECIAL));

}



static ssize_t set_phy_flash_cfg(struct device *dev,

static ssize_t phy_flash_cfg_store(struct device *dev,

				   struct device_attribute *attr,

				   const char *buf, size_t count)

{
@@ -396,7 +396,7 @@ static ssize_t set_phy_flash_cfg(struct device *dev, 
	return err ? err : count;

}



static DEVICE_ATTR(phy_flash_cfg, 0644, show_phy_flash_cfg, set_phy_flash_cfg);

static DEVICE_ATTR_RW(phy_flash_cfg);



static void sfe4001_fini(struct ef4_nic *efx)

{