Commit 48e81868 authored by Tony O'Brien's avatar Tony O'Brien Committed by Guenter Roeck
Browse files

hwmon: (adt7475) Fix masking of hysteresis registers 



The wrong bits are masked in the hysteresis register; indices 0 and 2
should zero bits [7:4] and preserve bits [3:0], and index 1 should zero
bits [3:0] and preserve bits [7:4].

Fixes: 1c301fc5 ("hwmon: Add a driver for the ADT7475 hardware monitoring chip")
Signed-off-by: default avatarTony O'Brien <tony.obrien@alliedtelesis.co.nz>
Link: https://lore.kernel.org/r/20230222005228.158661-3-tony.obrien@alliedtelesis.co.nz


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 5f8d1e3b

drivers/hwmon/adt7475.c

+2 −2
Original line number Diff line number Diff line
@@ -488,10 +488,10 @@ static ssize_t temp_store(struct device *dev, struct device_attribute *attr, 
		val = (temp - val) / 1000;



		if (sattr->index != 1) {

			data->temp[HYSTERSIS][sattr->index] &= 0xF0;

			data->temp[HYSTERSIS][sattr->index] &= 0x0F;

			data->temp[HYSTERSIS][sattr->index] |= (val & 0xF) << 4;

		} else {

			data->temp[HYSTERSIS][sattr->index] &= 0x0F;

			data->temp[HYSTERSIS][sattr->index] &= 0xF0;

			data->temp[HYSTERSIS][sattr->index] |= (val & 0xF);

		}