Commit 48d5fd06 authored Nov 03, 2021 by Kees Cook

selftests/seccomp: Stop USER_NOTIF test if kcmp() fails

If kcmp() fails during the USER_NOTIF test, the test is likely to hang,
so switch from EXPECT to ASSERT.

Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Will Drewry <wad@chromium.org>
Cc: linux-kselftest@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Link: https://lore.kernel.org/r/20211103163039.2104830-2-keescook@chromium.org

parent d9bbdbf3

tools/testing/selftests/seccomp/seccomp_bpf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4087,7 +4087,7 @@ TEST(user_notification_addfd)
		* lowest available fd to be assigned here.
		*/
		EXPECT_EQ(fd, nextfd++);
		EXPECT_EQ(filecmp(getpid(), pid, memfd, fd), 0);
		ASSERT_EQ(filecmp(getpid(), pid, memfd, fd), 0);

		/*
		* This sets the ID of the ADD FD to the last request plus 1. The