Commit 48b47f0c authored by Namjae Jeon's avatar Namjae Jeon Committed by Steve French
Browse files

ksmbd: fix uninitialized pointer read in ksmbd_vfs_rename() 



Uninitialized rd.delegated_inode can be used in vfs_rename().
Fix this by setting rd.delegated_inode to NULL to avoid the uninitialized
read.

Fixes: 74d7970f ("ksmbd: fix racy issue from using ->d_parent and ->d_name")
Reported-by: default avatarCoverity Scan <scan-admin@coverity.com>
Signed-off-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 0d85b27b

fs/smb/server/vfs.c

+1 −0
Original line number Diff line number Diff line
@@ -743,6 +743,7 @@ int ksmbd_vfs_rename(struct ksmbd_work *work, const struct path *old_path, 
	rd.new_dir		= new_path.dentry->d_inode,

	rd.new_dentry		= new_dentry,

	rd.flags		= flags,

	rd.delegated_inode	= NULL,

	err = vfs_rename(&rd);

	if (err)

		ksmbd_debug(VFS, "vfs_rename failed err %d\n", err);