Commit 48af14fb authored by Liang He's avatar Liang He Committed by Krzysztof Kozlowski
Browse files

memory: of: Fix refcount leak bug in of_lpddr3_get_ddr_timings() 



We should add the of_node_put() when breaking out of
for_each_child_of_node() as it will automatically increase
and decrease the refcount.

Fixes: 976897dd ("memory: Extend of_memory with LPDDR3 support")
Signed-off-by: default avatarLiang He <windhl@126.com>
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220719085640.1210583-2-windhl@126.com
parent 05215fb3

drivers/memory/of_memory.c

+1 −0
Original line number Diff line number Diff line
@@ -285,6 +285,7 @@ const struct lpddr3_timings 
		if (of_device_is_compatible(np_tim, tim_compat)) {

			if (of_lpddr3_do_get_timings(np_tim, &timings[i])) {

				devm_kfree(dev, timings);

				of_node_put(np_tim);

				goto default_timings;

			}

			i++;