Commit 48ae638b authored by Salah Triki's avatar Salah Triki Committed by Vinod Koul
Browse files

ppc4xx: replace sscanf() by kstrtoul() 



Fix the checkpatch.pl warning: "Prefer kstrto<type> to single variable sscanf".

Signed-off-by: default avatarSalah Triki <salah.triki@gmail.com>
Link: https://lore.kernel.org/r/20210710165432.GA690401@pc


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 2b5b7405

drivers/dma/ppc4xx/adma.c

+9 −3
Original line number Diff line number Diff line
@@ -4319,6 +4319,7 @@ static ssize_t enable_store(struct device_driver *dev, const char *buf, 
			    size_t count)

{

	unsigned long val;

	int err;



	if (!count || count > 11)

		return -EINVAL;
@@ -4327,7 +4328,10 @@ static ssize_t enable_store(struct device_driver *dev, const char *buf, 
		return -EFAULT;



	/* Write a key */

	sscanf(buf, "%lx", &val);

	err = kstrtoul(buf, 16, &val);

	if (err)

		return err;



	dcr_write(ppc440spe_mq_dcr_host, DCRN_MQ0_XORBA, val);

	isync();
@@ -4368,7 +4372,7 @@ static ssize_t poly_store(struct device_driver *dev, const char *buf, 
			  size_t count)

{

	unsigned long reg, val;



	int err;

#ifdef CONFIG_440SP

	/* 440SP uses default 0x14D polynomial only */

	return -EINVAL;
@@ -4378,7 +4382,9 @@ static ssize_t poly_store(struct device_driver *dev, const char *buf, 
		return -EINVAL;



	/* e.g., 0x14D or 0x11D */

	sscanf(buf, "%lx", &val);

	err = kstrtoul(buf, 16, &val);

	if (err)

		return err;



	if (val & ~0x1FF)

		return -EINVAL;