Commit 489bfc51 authored by Pali Rohár's avatar Pali Rohár Committed by Lorenzo Pieralisi
Browse files

PCI: mvebu: Check that PCI bridge specified in DT has function number zero 

Driver cannot handle PCI bridges at non-zero function address. So add
appropriate check. Currently all in-tree kernel DTS files set PCI bridge
function to zero.

Link: https://lore.kernel.org/r/20211125124605.25915-4-pali@kernel.org


Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
parent 5d18d702

drivers/pci/controller/pci-mvebu.c

+5 −0
Original line number Diff line number Diff line
@@ -845,6 +845,11 @@ static int mvebu_pcie_parse_port(struct mvebu_pcie *pcie, 
	port->devfn = of_pci_get_devfn(child);

	if (port->devfn < 0)

		goto skip;

	if (PCI_FUNC(port->devfn) != 0) {

		dev_err(dev, "%s: invalid function number, must be zero\n",

			port->name);

		goto skip;

	}



	ret = mvebu_get_tgt_attr(dev->of_node, port->devfn, IORESOURCE_MEM,

				 &port->mem_target, &port->mem_attr);