Commit 488ef44c authored by Chris Morgan's avatar Chris Morgan Committed by Sebastian Reichel
Browse files

power: supply: rk817: Fix node refcount leak 



Dan Carpenter reports that the Smatch static checker warning has found
that there is another refcount leak in the probe function. While
of_node_put() was added in one of the return paths, it should in
fact be added for ALL return paths that return an error and at driver
removal time.

Fixes: 54c03bfd ("power: supply: Fix refcount leak in rk817_charger_probe")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Closes: https://lore.kernel.org/linux-pm/dc0bb0f8-212d-4be7-be69-becd2a3f9a80@kili.mountain/


Signed-off-by: default avatarChris Morgan <macromorgan@hotmail.com>
Link: https://lore.kernel.org/r/20230920145644.57964-1-macroalpha82@gmail.com


Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 3dc0bab2

drivers/power/supply/rk817_charger.c

+12 −3
Original line number Diff line number Diff line
@@ -1045,6 +1045,13 @@ static void rk817_charging_monitor(struct work_struct *work) 
	queue_delayed_work(system_wq, &charger->work, msecs_to_jiffies(8000));

}



static void rk817_cleanup_node(void *data)

{

	struct device_node *node = data;



	of_node_put(node);

}



static int rk817_charger_probe(struct platform_device *pdev)

{

	struct rk808 *rk808 = dev_get_drvdata(pdev->dev.parent);
@@ -1061,11 +1068,13 @@ static int rk817_charger_probe(struct platform_device *pdev) 
	if (!node)

		return -ENODEV;



	ret = devm_add_action_or_reset(&pdev->dev, rk817_cleanup_node, node);

	if (ret)

		return ret;



	charger = devm_kzalloc(&pdev->dev, sizeof(*charger), GFP_KERNEL);

	if (!charger) {

		of_node_put(node);

	if (!charger)

		return -ENOMEM;

	}



	charger->rk808 = rk808;