Commit 488e0bf7 authored by Esina Ekaterina's avatar Esina Ekaterina Committed by Jakub Kicinski
Browse files

net: wan: Add checks for NULL for utdm in undo_uhdlc_init and unmap_si_regs 



If uhdlc_priv_tsa != 1 then utdm is not initialized.
And if ret != NULL then goto undo_uhdlc_init, where
utdm is dereferenced. Same if dev == NULL.

Found by Astra Linux on behalf of Linux Verification Center
(linuxtesting.org) with SVACE.

Fixes: 8d68100a ("soc/fsl/qe: fix err handling of ucc_of_parse_tdm")
Signed-off-by: default avatarEsina Ekaterina <eesina@astralinux.ru>
Link: https://lore.kernel.org/r/20230112074703.13558-1-eesina@astralinux.ru


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4bb4db7f

drivers/net/wan/fsl_ucc_hdlc.c

+4 −2
Original line number Diff line number Diff line
@@ -1243,8 +1243,10 @@ static int ucc_hdlc_probe(struct platform_device *pdev) 
free_dev:

	free_netdev(dev);

undo_uhdlc_init:

	if (utdm)

		iounmap(utdm->siram);

unmap_si_regs:

	if (utdm)

		iounmap(utdm->si_regs);

free_utdm:

	if (uhdlc_priv->tsa)