Commit 48729226 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by Alexei Starovoitov
Browse files

selftests: bpf: break up the rest of test_verifier 



Break up the rest of test_verifier tests into separate
files.

Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: default avatarJiong Wang <jiong.wang@netronome.com>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 40f2fbd5

tools/testing/selftests/bpf/test_verifier.c

+0 −6149

File changed.

Preview size limit exceeded, changes collapsed.

tools/testing/selftests/bpf/verifier/basic_instr.c

+42 −0
Original line number Diff line number Diff line
@@ -90,3 +90,45 @@ 
	},

	.result = ACCEPT,

},

{

	"invalid 64-bit BPF_END",

	.insns = {

	BPF_MOV32_IMM(BPF_REG_0, 0),

	{

		.code  = BPF_ALU64 | BPF_END | BPF_TO_LE,

		.dst_reg = BPF_REG_0,

		.src_reg = 0,

		.off   = 0,

		.imm   = 32,

	},

	BPF_EXIT_INSN(),

	},

	.errstr = "unknown opcode d7",

	.result = REJECT,

},

{

	"mov64 src == dst",

	.insns = {

	BPF_MOV64_IMM(BPF_REG_2, 0),

	BPF_MOV64_REG(BPF_REG_2, BPF_REG_2),

	// Check bounds are OK

	BPF_ALU64_REG(BPF_ADD, BPF_REG_1, BPF_REG_2),

	BPF_MOV64_IMM(BPF_REG_0, 0),

	BPF_EXIT_INSN(),

	},

	.prog_type = BPF_PROG_TYPE_SCHED_CLS,

	.result = ACCEPT,

},

{

	"mov64 src != dst",

	.insns = {

	BPF_MOV64_IMM(BPF_REG_3, 0),

	BPF_MOV64_REG(BPF_REG_2, BPF_REG_3),

	// Check bounds are OK

	BPF_ALU64_REG(BPF_ADD, BPF_REG_1, BPF_REG_2),

	BPF_MOV64_IMM(BPF_REG_0, 0),

	BPF_EXIT_INSN(),

	},

	.prog_type = BPF_PROG_TYPE_SCHED_CLS,

	.result = ACCEPT,

},

tools/testing/selftests/bpf/verifier/bounds_deduction.c

0 → 100644
+124 −0
Original line number Diff line number Diff line 
{

	"check deducing bounds from const, 1",

	.insns = {

		BPF_MOV64_IMM(BPF_REG_0, 1),

		BPF_JMP_IMM(BPF_JSGE, BPF_REG_0, 1, 0),

		BPF_ALU64_REG(BPF_SUB, BPF_REG_0, BPF_REG_1),

		BPF_EXIT_INSN(),

	},

	.result = REJECT,

	.errstr = "R0 tried to subtract pointer from scalar",

},

{

	"check deducing bounds from const, 2",

	.insns = {

		BPF_MOV64_IMM(BPF_REG_0, 1),

		BPF_JMP_IMM(BPF_JSGE, BPF_REG_0, 1, 1),

		BPF_EXIT_INSN(),

		BPF_JMP_IMM(BPF_JSLE, BPF_REG_0, 1, 1),

		BPF_EXIT_INSN(),

		BPF_ALU64_REG(BPF_SUB, BPF_REG_1, BPF_REG_0),

		BPF_EXIT_INSN(),

	},

	.result = ACCEPT,

	.retval = 1,

},

{

	"check deducing bounds from const, 3",

	.insns = {

		BPF_MOV64_IMM(BPF_REG_0, 0),

		BPF_JMP_IMM(BPF_JSLE, BPF_REG_0, 0, 0),

		BPF_ALU64_REG(BPF_SUB, BPF_REG_0, BPF_REG_1),

		BPF_EXIT_INSN(),

	},

	.result = REJECT,

	.errstr = "R0 tried to subtract pointer from scalar",

},

{

	"check deducing bounds from const, 4",

	.insns = {

		BPF_MOV64_IMM(BPF_REG_0, 0),

		BPF_JMP_IMM(BPF_JSLE, BPF_REG_0, 0, 1),

		BPF_EXIT_INSN(),

		BPF_JMP_IMM(BPF_JSGE, BPF_REG_0, 0, 1),

		BPF_EXIT_INSN(),

		BPF_ALU64_REG(BPF_SUB, BPF_REG_1, BPF_REG_0),

		BPF_EXIT_INSN(),

	},

	.result = ACCEPT,

},

{

	"check deducing bounds from const, 5",

	.insns = {

		BPF_MOV64_IMM(BPF_REG_0, 0),

		BPF_JMP_IMM(BPF_JSGE, BPF_REG_0, 1, 1),

		BPF_ALU64_REG(BPF_SUB, BPF_REG_0, BPF_REG_1),

		BPF_EXIT_INSN(),

	},

	.result = REJECT,

	.errstr = "R0 tried to subtract pointer from scalar",

},

{

	"check deducing bounds from const, 6",

	.insns = {

		BPF_MOV64_IMM(BPF_REG_0, 0),

		BPF_JMP_IMM(BPF_JSGE, BPF_REG_0, 0, 1),

		BPF_EXIT_INSN(),

		BPF_ALU64_REG(BPF_SUB, BPF_REG_0, BPF_REG_1),

		BPF_EXIT_INSN(),

	},

	.result = REJECT,

	.errstr = "R0 tried to subtract pointer from scalar",

},

{

	"check deducing bounds from const, 7",

	.insns = {

		BPF_MOV64_IMM(BPF_REG_0, ~0),

		BPF_JMP_IMM(BPF_JSGE, BPF_REG_0, 0, 0),

		BPF_ALU64_REG(BPF_SUB, BPF_REG_1, BPF_REG_0),

		BPF_LDX_MEM(BPF_W, BPF_REG_0, BPF_REG_1,

			    offsetof(struct __sk_buff, mark)),

		BPF_EXIT_INSN(),

	},

	.result = REJECT,

	.errstr = "dereference of modified ctx ptr",

	.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,

},

{

	"check deducing bounds from const, 8",

	.insns = {

		BPF_MOV64_IMM(BPF_REG_0, ~0),

		BPF_JMP_IMM(BPF_JSGE, BPF_REG_0, 0, 1),

		BPF_ALU64_REG(BPF_ADD, BPF_REG_1, BPF_REG_0),

		BPF_LDX_MEM(BPF_W, BPF_REG_0, BPF_REG_1,

			    offsetof(struct __sk_buff, mark)),

		BPF_EXIT_INSN(),

	},

	.result = REJECT,

	.errstr = "dereference of modified ctx ptr",

	.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,

},

{

	"check deducing bounds from const, 9",

	.insns = {

		BPF_MOV64_IMM(BPF_REG_0, 0),

		BPF_JMP_IMM(BPF_JSGE, BPF_REG_0, 0, 0),

		BPF_ALU64_REG(BPF_SUB, BPF_REG_0, BPF_REG_1),

		BPF_EXIT_INSN(),

	},

	.result = REJECT,

	.errstr = "R0 tried to subtract pointer from scalar",

},

{

	"check deducing bounds from const, 10",

	.insns = {

		BPF_MOV64_IMM(BPF_REG_0, 0),

		BPF_JMP_IMM(BPF_JSLE, BPF_REG_0, 0, 0),

		/* Marks reg as unknown. */

		BPF_ALU64_IMM(BPF_NEG, BPF_REG_0, 0),

		BPF_ALU64_REG(BPF_SUB, BPF_REG_0, BPF_REG_1),

		BPF_EXIT_INSN(),

	},

	.result = REJECT,

	.errstr = "math between ctx pointer and register with unbounded min value is not allowed",

},

tools/testing/selftests/bpf/verifier/bpf_get_stack.c

0 → 100644
+44 −0
Original line number Diff line number Diff line 
{

	"bpf_get_stack return R0 within range",

	.insns = {

	BPF_MOV64_REG(BPF_REG_6, BPF_REG_1),

	BPF_ST_MEM(BPF_DW, BPF_REG_10, -8, 0),

	BPF_MOV64_REG(BPF_REG_2, BPF_REG_10),

	BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -8),

	BPF_LD_MAP_FD(BPF_REG_1, 0),

	BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, BPF_FUNC_map_lookup_elem),

	BPF_JMP_IMM(BPF_JEQ, BPF_REG_0, 0, 28),

	BPF_MOV64_REG(BPF_REG_7, BPF_REG_0),

	BPF_MOV64_IMM(BPF_REG_9, sizeof(struct test_val)),

	BPF_MOV64_REG(BPF_REG_1, BPF_REG_6),

	BPF_MOV64_REG(BPF_REG_2, BPF_REG_7),

	BPF_MOV64_IMM(BPF_REG_3, sizeof(struct test_val)),

	BPF_MOV64_IMM(BPF_REG_4, 256),

	BPF_EMIT_CALL(BPF_FUNC_get_stack),

	BPF_MOV64_IMM(BPF_REG_1, 0),

	BPF_MOV64_REG(BPF_REG_8, BPF_REG_0),

	BPF_ALU64_IMM(BPF_LSH, BPF_REG_8, 32),

	BPF_ALU64_IMM(BPF_ARSH, BPF_REG_8, 32),

	BPF_JMP_REG(BPF_JSLT, BPF_REG_1, BPF_REG_8, 16),

	BPF_ALU64_REG(BPF_SUB, BPF_REG_9, BPF_REG_8),

	BPF_MOV64_REG(BPF_REG_2, BPF_REG_7),

	BPF_ALU64_REG(BPF_ADD, BPF_REG_2, BPF_REG_8),

	BPF_MOV64_REG(BPF_REG_1, BPF_REG_9),

	BPF_ALU64_IMM(BPF_LSH, BPF_REG_1, 32),

	BPF_ALU64_IMM(BPF_ARSH, BPF_REG_1, 32),

	BPF_MOV64_REG(BPF_REG_3, BPF_REG_2),

	BPF_ALU64_REG(BPF_ADD, BPF_REG_3, BPF_REG_1),

	BPF_MOV64_REG(BPF_REG_1, BPF_REG_7),

	BPF_MOV64_IMM(BPF_REG_5, sizeof(struct test_val)),

	BPF_ALU64_REG(BPF_ADD, BPF_REG_1, BPF_REG_5),

	BPF_JMP_REG(BPF_JGE, BPF_REG_3, BPF_REG_1, 4),

	BPF_MOV64_REG(BPF_REG_1, BPF_REG_6),

	BPF_MOV64_REG(BPF_REG_3, BPF_REG_9),

	BPF_MOV64_IMM(BPF_REG_4, 0),

	BPF_EMIT_CALL(BPF_FUNC_get_stack),

	BPF_EXIT_INSN(),

	},

	.fixup_map_hash_48b = { 4 },

	.result = ACCEPT,

	.prog_type = BPF_PROG_TYPE_TRACEPOINT,

},

tools/testing/selftests/bpf/verifier/calls.c

0 → 100644
+1942 −0

File added.

Preview size limit exceeded, changes collapsed.