Unverified Commit 482c23fb authored by Martin Povišer's avatar Martin Povišer Committed by Mark Brown
Browse files

ASoC: tas2770: Drop conflicting set_bias_level power setting 



The driver is setting the PWR_CTRL field in both the set_bias_level
callback and on DAPM events of the DAC widget (and also in the
mute_stream method). Drop the set_bias_level callback altogether as the
power setting it does is in conflict with the other code paths.

Fixes: 1a476abc ("tas2770: add tas2770 smart PA kernel driver")
Signed-off-by: default avatarMartin Povišer <povik+lin@cutebit.org>
Link: https://lore.kernel.org/r/20220808141246.5749-4-povik+lin@cutebit.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent bf54d97a

sound/soc/codecs/tas2770.c

+0 −33
Original line number Diff line number Diff line
@@ -46,38 +46,6 @@ static void tas2770_reset(struct tas2770_priv *tas2770) 
	usleep_range(1000, 2000);

}



static int tas2770_set_bias_level(struct snd_soc_component *component,

				 enum snd_soc_bias_level level)

{

	struct tas2770_priv *tas2770 =

			snd_soc_component_get_drvdata(component);



	switch (level) {

	case SND_SOC_BIAS_ON:

		snd_soc_component_update_bits(component, TAS2770_PWR_CTRL,

					      TAS2770_PWR_CTRL_MASK,

					      TAS2770_PWR_CTRL_ACTIVE);

		break;

	case SND_SOC_BIAS_STANDBY:

	case SND_SOC_BIAS_PREPARE:

		snd_soc_component_update_bits(component, TAS2770_PWR_CTRL,

					      TAS2770_PWR_CTRL_MASK,

					      TAS2770_PWR_CTRL_MUTE);

		break;

	case SND_SOC_BIAS_OFF:

		snd_soc_component_update_bits(component, TAS2770_PWR_CTRL,

					      TAS2770_PWR_CTRL_MASK,

					      TAS2770_PWR_CTRL_SHUTDOWN);

		break;



	default:

		dev_err(tas2770->dev, "wrong power level setting %d\n", level);

		return -EINVAL;

	}



	return 0;

}



#ifdef CONFIG_PM

static int tas2770_codec_suspend(struct snd_soc_component *component)

{
@@ -555,7 +523,6 @@ static const struct snd_soc_component_driver soc_component_driver_tas2770 = { 
	.probe			= tas2770_codec_probe,

	.suspend		= tas2770_codec_suspend,

	.resume			= tas2770_codec_resume,

	.set_bias_level = tas2770_set_bias_level,

	.controls		= tas2770_snd_controls,

	.num_controls		= ARRAY_SIZE(tas2770_snd_controls),

	.dapm_widgets		= tas2770_dapm_widgets,