Commit 4817a52b authored by Peter Zijlstra's avatar Peter Zijlstra
Browse files

seqlock,lockdep: Fix seqcount_latch_init() 



seqcount_init() must be a macro in order to preserve the static
variable that is used for the lockdep key. Don't then wrap it in an
inline function, which destroys that.

Luckily there aren't many users of this function, but fix it before it
becomes a problem.

Fixes: 80793c34 ("seqlock: Introduce seqcount_latch_t")
Reported-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/YEeFEbNUVkZaXDp4@hirez.programming.kicks-ass.net
parent d5b0e067

include/linux/seqlock.h

+1 −4
Original line number Diff line number Diff line
@@ -664,10 +664,7 @@ typedef struct { 
 * seqcount_latch_init() - runtime initializer for seqcount_latch_t

 * @s: Pointer to the seqcount_latch_t instance

 */

static inline void seqcount_latch_init(seqcount_latch_t *s)

{

	seqcount_init(&s->seqcount);

}

#define seqcount_latch_init(s) seqcount_init(&(s)->seqcount)



/**

 * raw_read_seqcount_latch() - pick even/odd latch data copy