Commit 48079e7f authored by Sukadev Bhattiprolu's avatar Sukadev Bhattiprolu Committed by David S. Miller
Browse files

ibmvnic: don't spin in tasklet 



ibmvnic_tasklet() continuously spins waiting for responses to all
capability requests. It does this to avoid encountering an error
during initialization of the vnic. However if there is a bug in the
VIOS and we do not receive a response to one or more queries the
tasklet ends up spinning continuously leading to hard lock ups.

If we fail to receive a message from the VIOS it is reasonable to
timeout the login attempt rather than spin indefinitely in the tasklet.

Fixes: 249168ad ("ibmvnic: Make CRQ interrupt tasklet wait for all capabilities crqs")
Signed-off-by: default avatarSukadev Bhattiprolu <sukadev@linux.ibm.com>
Reviewed-by: default avatarDany Madden <drt@linux.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 151b6a5c

drivers/net/ethernet/ibm/ibmvnic.c

+0 −6
Original line number Diff line number Diff line
@@ -5499,12 +5499,6 @@ static void ibmvnic_tasklet(struct tasklet_struct *t) 
			ibmvnic_handle_crq(crq, adapter);

			crq->generic.first = 0;

		}



		/* remain in tasklet until all

		 * capabilities responses are received

		 */

		if (!adapter->wait_capability)

			done = true;

	}

	/* if capabilities CRQ's were sent in this tasklet, the following

	 * tasklet must wait until all responses are received